fix: don't just show the creation time for threads in sidebar#1136
Open
nmggithub wants to merge 2 commits intopingdotgg:mainfrom
Open
fix: don't just show the creation time for threads in sidebar#1136nmggithub wants to merge 2 commits intopingdotgg:mainfrom
nmggithub wants to merge 2 commits intopingdotgg:mainfrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
bot
added
size:XS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Should resolve #973. This updates the date indicator for threads as the thread itself updates. We can decided which dates we actually want to use as the canonical reference points.
EDIT: Changed strategies to use the last chat message's
createdAt. Macroscope's summary below is out-of-date.Why
Users expect the date indicator to change as they interact with the thread.
UI Changes
Before (
main) and after (`sidebar-dates', my branch) on a thread I just got a response from:Checklist
I included a video for animation/interaction changesNote
Fix sidebar thread timestamps to show last visited or latest turn time
Thread items in the sidebar were always showing
createdAt, ignoring more recent activity. Sidebar.tsx now useslastVisitedAtfirst, thenlatestTurn.completedAt, falling back tocreatedAt.Macroscope summarized eb686b0.